Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

tinycrypt: Use a do..while loop and remove explicit CC#57

Open
rilysh wants to merge 1 commit intointel:masterfrom
mystuffs:master
Open

tinycrypt: Use a do..while loop and remove explicit CC#57
rilysh wants to merge 1 commit intointel:masterfrom
mystuffs:master

Conversation

@rilysh
Copy link

@rilysh rilysh commented Oct 28, 2023

Hello,

  1. In ctr_prng.c, the arrInc() function uses a for loop which requires defining a variable before initializing. As we're already going backward there, we can just replace the for loop with a do..while loop instead.
  2. Makefile explicitly uses GCC, however, most BSD systems don't use GCC, instead, they ship Clang by default. Dropping explicitly stating the compiler is much better as we can safely assume the CC variable already defaults to an existing/installed compiler.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant